Skip to content

Conversation

@OblongNoodle
Copy link

@runelite-github-app
Copy link

runelite-github-app bot commented Nov 1, 2025

@runelite-github-app
Copy link

runelite-github-app bot commented Nov 1, 2025

This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed.


Internal use only: Reviewer details Maintainer details

@riktenx
Copy link
Member

riktenx commented Nov 30, 2025

This is adding too many config keys, we can't reasonably allow plugins to just arbitrarily add 3000+ boolean configs for something like this. If you want to continue pursuing getting this merged you will need to change the plugin to read/write state somewhere other than the runelite profile (e.g. to a file on disk in the .runelite directory).

@riktenx riktenx added the waiting for author waiting for the pr author to make changes or respond to questions label Nov 30, 2025
@LlemonDuck
Copy link
Contributor

Considering the plugin doesn't actually interface with the game at all, I'd challenge whether this really even needs to be a runelite plugin. Can't this just be a website or a google doc/sheet?

@OblongNoodle OblongNoodle reopened this Dec 2, 2025
@runelite-github-app runelite-github-app bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Dec 2, 2025
@Felanbird Felanbird added the waiting for author waiting for the pr author to make changes or respond to questions label Dec 2, 2025
Update to file-based storage implementation
@runelite-github-app runelite-github-app bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Dec 2, 2025
@OblongNoodle
Copy link
Author

Considering the plugin doesn't actually interface with the game at all, I'd challenge whether this really even needs to be a runelite plugin. Can't this just be a website or a google doc/sheet?

Reason for plugin was specifically for easy access while playing without alt-tabbing. Laptop user myself and using my other custom plugins like this has been very nice. This one in particular I got requested by a friend to have added to the official client.

@riktenx
Copy link
Member

riktenx commented Dec 2, 2025

We are willing to review it but you MUST address the config issue I mentioned above.

@riktenx riktenx added the waiting for author waiting for the pr author to make changes or respond to questions label Dec 2, 2025
Plugin repository structure should have build files at root, not in subdirectory
@runelite-github-app runelite-github-app bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Dec 2, 2025
Fix Gson injection
Added LICENSE
@OblongNoodle
Copy link
Author

We are willing to review it but you MUST address the config issue I mentioned above.

Fix implemented, should be ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants