-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Create ironguide #9391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Create ironguide #9391
Conversation
|
New plugin |
|
This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed. Internal use only: Reviewer details Maintainer details |
|
This is adding too many config keys, we can't reasonably allow plugins to just arbitrarily add 3000+ boolean configs for something like this. If you want to continue pursuing getting this merged you will need to change the plugin to read/write state somewhere other than the runelite profile (e.g. to a file on disk in the .runelite directory). |
|
Considering the plugin doesn't actually interface with the game at all, I'd challenge whether this really even needs to be a runelite plugin. Can't this just be a website or a google doc/sheet? |
Update to file-based storage implementation
Reason for plugin was specifically for easy access while playing without alt-tabbing. Laptop user myself and using my other custom plugins like this has been very nice. This one in particular I got requested by a friend to have added to the official client. |
|
We are willing to review it but you MUST address the config issue I mentioned above. |
Plugin repository structure should have build files at root, not in subdirectory
Fix Gson injection
Added LICENSE
Fix implemented, should be ready for review. |
B0aty Iron guide checklist https://oldschool.runescape.wiki/w/Guide:B0aty_HCIM_Guide_V3